fix: use HttpClient for fetching tiles #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
One improvment to consider is to remove |
Owner
|
Thanks a lot - it looks good on the first glance. Will need to dig a bit deeper, but I'm really busy at work right now, so I might need a few days. |
Contributor
|
Please grab some christmas cookies and hide away somewhere quiet to merge the PR and push a new version. I'm a +1 for experiencing a broken UI. Please advise if there is anything I can do to help. |
Owner
|
Lots of things changed so it took some time, but I released 2.8.1 yesterday. This one will be next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix removes the use of
URLConnectionfor fetching tiles. We useHttpClientinstead.the
HttpClientmanages its own thread pool but keeping the attributes that configure the internal executor ensures a gentle pollingThe client is configured with a 5 sec timeout
Tested on examples by changing dependency path to system targetting local jar built and it works. Hope it works on your side
The exception
URISyntaxExceptionrelated to url malformatting are thrown given that someone can provide custom tile provider